fix: remove dead Run Analysis button, URL-encode node IDs, replace Tailwind CDN#2
Merged
Merged
Conversation
…ilwind CDN - F1: Replace dead POST /api/analyze button with CLI instructions (index/enrich/serve) - F2: URL-encode node IDs in HTMX hx-get attributes using #uris.escapePathSegment() - F3: Build Tailwind CSS locally via existing Vite pipeline, remove CDN dependency Co-Authored-By: Paperclip <noreply@paperclip.ing> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…olors - F2: Switch /ui/node and /ui/fragments/detail from path variables to query parameters (?nodeId=...) to avoid Tomcat %2F rejection for node IDs containing slashes. Use #uris.escapeQueryStringParam() in templates. - F2: Update all th:href links in detail-panel, nodes-grid, and search-results to use query param format. - F2: Update ExplorerController endpoints and tests accordingly. - F3: Create separate explorer-tailwind.config.ts with original blue brand colors (#3b82f6/#2563eb) and 0.3s animation timing, avoiding regression in the React app's indigo branding. - F3: Revert React tailwind.config.ts to original (no template scanning). - F3: Add explorer.css to .gitignore as a build artifact. Co-Authored-By: Paperclip <noreply@paperclip.ing> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Addresses CTO review note: kindEntry['kind'] in Quick View button's hx-get was the only unencoded path segment. Low risk since kind values are ASCII enum names, but now consistent with the encoding pattern. Co-Authored-By: Paperclip <noreply@paperclip.ing> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This was referenced Apr 25, 2026
aksOps
added a commit
that referenced
this pull request
Apr 25, 2026
…C) (#90) Closes one of the audit gaps from RAN-46 AC #2 ("Workflow permissions: default to read-all, scoped up per job") + Scorecard Token-Permissions finding. Before: - ci-java.yml had no permissions declaration anywhere — relied on repo-default GITHUB_TOKEN scope (which can be write-all on older repos). - beta-java.yml + release-java.yml only had job-level scopes; missing the explicit top-level read-all that Scorecard checks for. After: - All three workflows declare `permissions: read-all` at the top level. - ci-java.yml's build job now declares `contents: read` explicitly (no other scopes needed — Sonar uses SONAR_TOKEN, not GITHUB_TOKEN). - beta-java.yml and release-java.yml keep their existing job-level `contents: write` (and `packages: write` for beta) which override the top-level for the deploy/tag steps. Audit confirmation (orthogonal to the (A)/(B) security-stack ruling still pending on RAN-46): - All `uses:` SHA-pinned across all 4 workflows (Pinned-Dependencies) - No pull_request_target anywhere (Dangerous-Workflow) - scorecard.yml already had `permissions: read-all` at top level
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/analyze. Replaced with CLI instructions showingcode-iq index/enrich/servepipeline.hx-getattributes using Thymeleaf#uris.escapePathSegment()to handle:and/characters in IDs likeyaml:path/to/file.yaml.build:explorer-cssnpm script, updated Tailwind config to scan Thymeleaf templates, createdexplorer.cssentry point.Test plan
code-iq serveon test project, verify styling renders correctly🤖 Generated with Claude Code